docs: inject services with recommended API and use takeUntilDestroyed #31915
+18
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeAkib
requested review from
andrewseguin and
crisbeto
and removed request for
a team
mmalerba
approved these changes
Sep 26, 2025
Member
|
PTAL at the linting failures. |
MeAkib
force-pushed
the
refactor/docs-theme-picker
branch
from
f7c55f3 to
c733dd4
Compare
JeanMeche
reviewed
Oct 2, 2025
- Updated service injection to use readonly fields. - Replaced manual subscription tracking with `takeUntilDestroyed`, removing the need for `OnDestroy` cleanup.
MeAkib
force-pushed
the
refactor/docs-theme-picker
branch
from
c733dd4 to
092edb3
Compare
JeanMeche
approved these changes
Oct 2, 2025
Contributor
adolgachev
pushed a commit
to adolgachev/components
that referenced
this pull request
Oct 19, 2025
…angular#31915) - Updated service injection to use readonly fields. - Replaced manual subscription tracking with `takeUntilDestroyed`, removing the need for `OnDestroy` cleanup.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
takeUntilDestroyed, removing the need forOnDestroycleanup.