Skip to content

docs: inject services with recommended API and use takeUntilDestroyed #31915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

docs: inject services with recommended API and use takeUntilDestroyed #31915

merged 1 commit into from
Oct 2, 2025

Conversation

MeAkib
Copy link
Contributor

@MeAkib MeAkib commented Sep 24, 2025

  • Updated service injection to use readonly fields.
  • Replaced manual subscription tracking with takeUntilDestroyed, removing the need for OnDestroy cleanup.

@MeAkib MeAkib requested a review from a team as a code owner September 24, 2025 17:14
@MeAkib MeAkib requested review from crisbeto and andrewseguin and removed request for a team September 24, 2025 17:14
@angular-robot angular-robot bot added the area: docs Related to the documentation label Sep 24, 2025
@JeanMeche
Copy link
Member

PTAL at the linting failures.

@MeAkib MeAkib force-pushed the refactor/docs-theme-picker branch from f7c55f3 to c733dd4 Compare October 2, 2025 13:40
@MeAkib MeAkib requested a review from mmalerba October 2, 2025 13:43
JeanMeche
JeanMeche reviewed Oct 2, 2025
View reviewed changes
@MeAkib
docs: inject services with recommended API and use takeUntilDestroyed
092edb3 
- Updated service injection to use readonly fields.
- Replaced manual subscription tracking with `takeUntilDestroyed`, removing the need for `OnDestroy` cleanup.
@MeAkib MeAkib force-pushed the refactor/docs-theme-picker branch from c733dd4 to 092edb3 Compare October 2, 2025 14:22
@MeAkib MeAkib requested a review from JeanMeche October 2, 2025 14:24
@JeanMeche JeanMeche added the target: patch This PR is targeted for the next patch release label Oct 2, 2025
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Oct 2, 2025
@mmalerba mmalerba merged commit faf1ef0 into angular:main Oct 2, 2025
28 checks passed
@mmalerba
Copy link
Contributor

mmalerba commented Oct 2, 2025

This PR was merged into the repository. The changes were merged into the following branches:

mmalerba pushed a commit that referenced this pull request Oct 2, 2025
@MeAkib @mmalerba
docs: inject services with recommended API and use takeUntilDestroyed (…
a5456ab 
…#31915)

- Updated service injection to use readonly fields.
- Replaced manual subscription tracking with `takeUntilDestroyed`, removing the need for `OnDestroy` cleanup.

(cherry picked from commit faf1ef0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto crisbeto is a code owner automatically assigned from angular/components-googlers

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner automatically assigned from angular/components-googlers

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MeAkib @JeanMeche @mmalerba